Merge lp:~aelkner/cando/filter_widget_bug into lp:~vcs-imports/cando/trunk

Proposed by Alan Elkner
Status: Needs review
Proposed branch: lp:~aelkner/cando/filter_widget_bug
Merge into: lp:~vcs-imports/cando/trunk
Diff against target: 24 lines (+3/-1)
2 files modified
CHANGES.txt (+1/-0)
src/cando/newskin/person.py (+2/-1)
To merge this branch: bzr merge lp:~aelkner/cando/filter_widget_bug
Reviewer Review Type Date Requested Status
Justas Sadzevičius (community) Approve
VCS imports Pending
Review via email: mp+39345@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Justas Sadzevičius (justas.sadzevicius) wrote :

Ouch. Yes, that definitely needs fixin.

review: Approve

Unmerged revisions

1052. By Alan Elkner <aelkner@ubuntu>

Fixed person filter widget bug where groups drop-down was empty

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CHANGES.txt'
--- CHANGES.txt 2010-08-23 03:33:55 +0000
+++ CHANGES.txt 2010-10-26 07:43:44 +0000
@@ -8,6 +8,7 @@
8- Renamed menu option to 'Import Competencies from CSV' and updated8- Renamed menu option to 'Import Competencies from CSV' and updated
9 the instructions and example in the 'Import Competencies from a CSV9 the instructions and example in the 'Import Competencies from a CSV
10 file' form10 file' form
11- Fixed person filter widget bug where groups drop-down was empty
1112
1213
132010.06.2 (2010-07-15)142010.06.2 (2010-07-15)
1415
=== modified file 'src/cando/newskin/person.py'
--- src/cando/newskin/person.py 2009-01-09 07:37:58 +0000
+++ src/cando/newskin/person.py 2010-10-26 07:43:44 +0000
@@ -35,7 +35,8 @@
3535
36 def groups(self):36 def groups(self):
37 groups = []37 groups = []
38 for id, group in IGroupContainer(ISchoolToolApplication, {}).items():38 container = IGroupContainer(ISchoolToolApplication(None), {})
39 for id, group in container.items():
39 groups.append({'id': id, 'title': "%s" % group.title})40 groups.append({'id': id, 'title': "%s" % group.title})
40 return groups41 return groups
4142

Subscribers

People subscribed via source and target branches

to all changes: