Code review comment for ~adrien/ubuntu/+source/ruby3.1:replace-expired-certificate

Revision history for this message
Adrien Nader (adrien) wrote :

Hi Sergio,

I've updated the merge requests. Sorry about the DEP-3 headers: I had put them in a previous "iteration" of the patch and subsequently lost them because there were several patches floating upstream in parallel. On the positive side, I noticed a specific merge of this change in the 3.1 branch upstream and was able to use the exact same commit hash now.

There is an upstream bug for this: Bug: https://bugs.ruby-lang.org/issues/20106
(I hadn't noticed it the previously)
But no ubuntu bug. I noticed this because of failing tests for migration (either of gnutls28 or of openssl, I don't remember).

As for the use of "merge", I can't see find where I used that. In any case, this is a patch from upstream, now present in 3.1, 3.2, and 3.3 branches but only released through the 3.2 branch. I'm reusing it without any change.

« Back to merge proposal