Code review comment for lp:~adorsaz/homebank/adv-budget-with-categories

Adrien Dorsaz (adorsaz) wrote :

Hi Maxime,

Thanks for this review, your suggestions are nice and well explained.

I've began to rename the dialog (and symbols), to build read-only by default and to re-order buttons on top.

For the bug of selection, I think I'll simply clear the current selection on view change, because there's a lot difference between them in the lines (especially between Expense and Credit which have only the total lines in common).

For the moment, the first lines in the tree are the "Incomes". Should I first display "Expense" to follow the order of top buttons ? (same question for the "Income" and "Expense" line of the "Totals" group ?)

Thanks again and see you !

« Back to merge proposal