Merge ~adobrawy/cloud-init:swap-linux into cloud-init:master
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Chad Smith | ||||
Proposed branch: | ~adobrawy/cloud-init:swap-linux | ||||
Merge into: | cloud-init:master | ||||
Diff against target: |
27 lines (+10/-3) 1 file modified
cloudinit/config/cc_mounts.py (+10/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chad Smith | Needs Information | ||
Review via email: mp+354680@code.launchpad.net |
Commit message
Do not use fallocate in swap file creation on xfs.
When creating a swap file on an xfs filesystem, fallocate cannot be used.
Doing so results in failure of swapon and a message like:
swapon: swapfile has holes
The solution here is to maintain a list (currently containing only XFS)
of filesystems where fallocate cannot be used. The, on those fileystems
use the slower but functional 'dd' method.
Description of the change
xfs, which is default on CentOS7 doesn't handle fallocate correctly when used with swapfiles.
Therefore we need to check if the FS is fallocate-safe. Not sure if other FS' are affected.
https:/
This is a friendly transfer of the pull-request originally reported on GitHub: https:/
I work with Krzysztof Biernat and I have obtained permission from him for such an operation.
Unmerged commits
- 435c907... by Adam Dobrawy <email address hidden>
- 124b107... by Adam Dobrawy <email address hidden>
Hi,
Thank you for contributing to cloud-init.
To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1].
If you have already signed it as an individual, your Launchpad user will be listed in the contributor- agreement- canonical launchpad group [2]. Unfortunately there is no easy way to check if an organization or company you are doing work for has signed. If you are unsure or have questions, email <email address hidden> or ping smoser in #cloud-init channel via freenode.
For information on how to sign, please see the HACKING document [3].
Thanks again, and please feel free to reach out with any questions.
– www.canonical. com/contributor s /launchpad. net/~contributo r-agreement- canonical/ +members cloudinit. readthedocs. io/en/latest/ topics/ hacking. html
[1] http://
[2] https:/
[3] http://