Code review comment for lp:~adiroiban/pocket-lint/travis-ci

Revision history for this message
Curtis Hovey (sinzui) wrote :

This branch conflicts with your pep8 branch that is merged.

I would prefer that
    python_version = sys.version_info
becomes
    IS_PY3 = IS_PY3
which can be imported from formatcheck...

...but is it needed. The py2 tests fail for me with the change. py2 and py3 both pass with "enclosed in double quotes"

First differing element 0:
(2, u'Expecting property name: line 2 column 1 (char 2)')
(2, 'Expecting property name enclosed in double quotes: line 2 column 1 (char 2)')

+ [(2,
- [(2, u'Expecting property name: line 2 column 1 (char 2)')]
? ^^^^^^

+ 'Expecting property name enclosed in double quotes: line 2 column 1 (char 2)')]
? ^^ ++++++++++++++++++++++++++

review: Needs Information (code)

« Back to merge proposal