Code review comment for lp:~adiroiban/pocket-lint/pocket-lint-css-lint

Revision history for this message
Curtis Hovey (sinzui) wrote :

Your library and integration looks good, but test_css is broken. test_css is getting the cssccc errors too.

I think we should treat this like the PythonChecker class where check() calls seperate methods for pyflakes and pep8. Maybe CSSChecker.check() chouls call check_cssutils() and check_cssccc(). Then the two tests modules could be tested separately. What do you think?

I am a little concerned that cssccc raises an error for an indented final brace. I am happy to change the good_css to make that test pass for now. I would like cssccc to permit subordinate indentation for the final brace in the future

I would like to factor CSSUtils out in the future because I think a faster grammar checker could be written that emphasises the current and future standards. Your library could be extended to do this.

review: Needs Information (code)

« Back to merge proposal