Code review comment for lp:~adiroiban/launchpad/bug-121520-merged

= Bug 121520 =
On https://translations.launchpad.net/+languages/st we can see that Leonardo Gregianin appears twice, one with this current account (leogregianin) and an old merged one, (leogregianin-merged.

We should not show merged accounts as they lead to „dead” pages.

== Proposed fix ==
Add a condition in the template to skip account with merged=True

== Tests ==
lp-test -t pofile-details

== Demo and Q/A ==
As I don't know how to create a merged account, and I assume it is not that trivial (no hints in the Factory) you can test it on staging
https://translations.staging.launchpad.net/+languages/st

The current page test is check that the valid/active contributors are displayed.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/templates/pofile-details.pt
  lib/lp/translations/templates/pofile-translate-contributors.pt