Launchpad itself

Code review comment for lp:~adeuring/launchpad/lp-lazr.jobrunner

  1. lp-lazr.jobrunner
  2. Merge into devel
Revision history for this message
Aaron Bentley (abentley) wrote :

Not landable yet because it assumes lazr.jobrunner is a development egg. "../lazr.jobrunner" should not be listed in buildout.cfg, and a version of lazr.jobrunner should be specified in versions.cfg.

runJob may not need to be overridden in BaseJobRunner. If not, please remove it.

job_str may not need to be overridden in BaseJobRunner. If not, please remove it.

review: Needs Fixing

« Back to merge proposal