Code review comment for lp:~adeuring/launchpad/bug-903852

Revision history for this message
Aaron Bentley (abentley) wrote :

Nice improvement.

A couple of small tweaks:
- Our style guide recommends "!Y.Lang.isUndefined()" (or isValue) rather than "!== undefined".
- You should be able to avoid the lint warning, yet write a readable loop using Y.each.

review: Approve

« Back to merge proposal