Code review comment for lp:~adeuring/launchpad/bug-739052-8

Revision history for this message
Abel Deuring (adeuring) wrote :

On 14.09.2011 21:50, Robert Collins wrote:
> There is a count estimator function in Launchpad already - was it
> unsuitable for use by this?

Well, I _could_ have tweaked it: It wants a traditional psycopg cursor,
while we have Storm result set.

Aaron already suggested to make a general function from the method -- I
was simply too lazy to do that: proper test setup etc etc.

I am already working a bit too long on the batching stuff, considering
that I naively started with the intent to fix "just" bug 739052 ;) OK,
there were a few interruptions...

And before the Orange squad starts again feature work, I'd like to go
back to the main interruption: the HWDB problems we had recently.

I think we need urgently a much closer "feedback loop" for checkbox (the
HWDB client that submits the reports): We should process the reports
immediately when checkbox submits the data so that the client can notice
any problems immediately.

Sure, not having an general "length estimation function" for Storm
result sets is wart -- but a much smaller one than the HWDB issues...

« Back to merge proposal