Code review comment for lp:~adeuring/launchpad/bug-702468

Revision history for this message
Henning Eggers (henninge) wrote :

Abel,
thank you for this update! It looks very well done to me. I have just one remaining request.

Please add a stub for selectUpstreamTranslation to SetCurrentTranslationTestMixin with a docstring and a "raise NotImplementedError". That makes it clearer where that is coming from. Also, you should either fix the parameter documentation in selectUpstreamTranslation ("tm" twice) or remove it completely (because it is pretty obvious ;).

Cheers,
Henning

review: Approve (code)

« Back to merge proposal