On 04.08.2010 02:52, Robert Collins wrote:
> Abel, could you do a small follow on patch for me?
>
> I'd like a little more prose/documentation in the docstrings for the
> views so that developers can see when they should use one or the other
> view class.
>
> rs=lifeless for such a tweak.
>
> Thanks,
> Rob
Robert,
I'd like to postpone this to when PQM is closed ;) reasons:
- I need to land at least two more branches to fix the "private bug
attachments" bug.
- ProxiedLFA, FileNavigationMixin, RedirectOrStream.*View could need a
bit more testing (I've added some unit tests for private attachments
that are in fact more like tests of FileNavigationMixin and
StreamOrRedirectLibraryFileAliasView)
- StreamOrRedirectLibraryFileAliasView currently lives in
lib.lp.bugs.browser.bugattachment, but it should move to
canonical.launchpad.browser.librarian
On 04.08.2010 02:52, Robert Collins wrote:
> Abel, could you do a small follow on patch for me?
>
> I'd like a little more prose/documentation in the docstrings for the
> views so that developers can see when they should use one or the other
> view class.
>
> rs=lifeless for such a tweak.
>
> Thanks,
> Rob
Robert,
I'd like to postpone this to when PQM is closed ;) reasons:
- I need to land at least two more branches to fix the "private bug ixin, RedirectOrStrea m.*View could need a ectLibraryFileA liasView) tLibraryFileAli asView currently lives in bugs.browser. bugattachment, but it should move to launchpad. browser. librarian
attachments" bug.
- ProxiedLFA, FileNavigationM
bit more testing (I've added some unit tests for private attachments
that are in fact more like tests of FileNavigationMixin and
StreamOrRedir
- StreamOrRedirec
lib.lp.
canonical.
Abel