Code review comment for lp:~adeuring/launchpad/bug-594247

Revision history for this message
Robert Collins (lifeless) wrote :

"
This decorator assumes that the Storm query returns BugTask
instances, which is not the case for BugTaskSet.searchBugIds().
So BugTaskSet._search() has an optional parameter "undecorated".
If it is True, _search() returns a plain Storm result set,
otherwise, it returns a DecoratedResultSet."

I have a thought here: the decorator is meant to be opaque. So why not
just return an appropriate one for the query being constructed?

I guess I'm saying that 'undecorated' is the what, not the why, and
some other approach might be clearer.

« Back to merge proposal