Launchpad itself

Code review comment for lp:~adeuring/launchpad/bug-594247

  1. bug-594247
  2. Merge into devel
Revision history for this message
Graham Binns (gmb) wrote :

Hi Abel,

As we discussed on IRC, I think you should get a review from someone more SQL / Storm savvy than I, since my brain seems to just skip off those parts of the code.

I'm happy with the rest of the diff, with just two comments:

> 94 + # Circular.

Please expand this to something less terse ;). ("Prevent circular
import problems." or something similar.)

> 319 + # Circular.

Here too.

review: Approve (code)

« Back to merge proposal