Code review comment for lp:~adeuring/launchpad/bug-39674-change-remaining-lfa-http_url

Revision history for this message
Deryck Hodge (deryck) wrote :

The changes generally look good, Abel. Thanks for all the work you've been doing to get this ready!

I have two minor requests:

1) If there are bugs for these related issues that are fixed, can you link the branch to them so they get marked fixed when this lands?

2) Can you add a comment in code explaining why the flush is required?

Consider this r=me with these minor changes.

Cheers,
deryck

review: Approve (code)

« Back to merge proposal