The changes generally look good, Abel. Thanks for all the work you've been doing to get this ready!
I have two minor requests:
1) If there are bugs for these related issues that are fixed, can you link the branch to them so they get marked fixed when this lands?
2) Can you add a comment in code explaining why the flush is required?
Consider this r=me with these minor changes.
Cheers, deryck
« Back to merge proposal
The changes generally look good, Abel. Thanks for all the work you've been doing to get this ready!
I have two minor requests:
1) If there are bugs for these related issues that are fixed, can you link the branch to them so they get marked fixed when this lands?
2) Can you add a comment in code explaining why the flush is required?
Consider this r=me with these minor changes.
Cheers,
deryck