Code review comment for lp:~adeuring/juju-core/1227574

Reviewers: mp+214520_code.launchpad.net,

Message:
Please take a look.

Description:
destroy-env should remove security groups

fix for bug 1227574.

The implementation is obvious, I think. As described in bug 1300755
it can happen that a security group cannot be deleted because it is
used in another environment. The Nova API call fails in this case,
so trying this call does not affect the other environment.

Unfortunately, goose hides the original error message, so Destroy()
ans StopInstance() cannot determine the exact reason of the failure.
Hence only a warning is logged.

https://code.launchpad.net/~adeuring/juju-core/1227574/+merge/214520

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/84470053/

Affected files (+168, -2 lines):
   A [revision details]
   M provider/openstack/local_test.go
   M provider/openstack/provider.go