Code review comment for lp:~adeuring/charmworld/1180118-check-if-charm-is-deleted

Revision history for this message
Abel Deuring (adeuring) wrote :

The two sequences available_charms() and db_charms() are now merged via dict.update(); CHARM_IMPORT_FILTER and limit are now used in all_charms().

But I am not sure if we should try to proof charm without LP branches: As you noted, this can lead to random behaviour when we have more than one worker.

Alternatively, we could pull the charm data from the main store when no LP data is available. But I am not sure if we care enough about this sort of "half-dead"/abandoned charms. (We should discuss though if it makes sense to pull the charm data from the store for _all_ charms and use that instead of the LP branches as our main source. This might avoid a few other possible inconsistencies.)

« Back to merge proposal