~addyess/layer-snap:akd/lp2037315/retry-and-debug-snap_refresh

Branch merges

Propose for merging

Merged into layer-snap:master at revision dc496ab2fd1240588e6e00240a23b5f5faa4b943

Haw Loeung: Approve (+1) on 2024-03-12

Kevin W Monroe: Pending requested 2023-09-25

Corey Bryant: Pending requested 2023-09-25

Diff: 63 lines (+31/-3)

2 files modified

lib/charms/layer/snap.py (+21/-3)
tests/unit/test_lib.py (+10/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

f7c35a7... by Adam Dyess on 2023-09-25

Retry and log errors on snap refresh

c1fb0f7... by Corey Bryant on 2023-08-16

Only pin tenacity to < 5.0.4 for trusty

Ubuntu Lunar uses python 3.11 where tenacity < 5.0.4 fails with:
"AttributeError: module 'asyncio' has no attribute 'coroutine'"

This is because the @asyncio.coroutine has been deprecated since
version 3.8 and was removed in 3.11:
https://docs.python.org/3.10/library/asyncio-task.html#generator-based-coroutines

LP: #2031439

Reviewed-on: https://code.launchpad.net/~corey.bryant/layer-snap/+git/layer-snap/+merge/449280
Reviewed-by: Haw Loeung <email address hidden>
Reviewed-by: Felipe Reyes <email address hidden>

d87f234... by Corey Bryant on 2023-08-16

Only pin tenacity to < 5.0.4 for trusty

Ubuntu Lunar uses python 3.11 where tenacity < 5.0.4 fails with:
"AttributeError: module 'asyncio' has no attribute 'coroutine'"

This is because the @asyncio.coroutine has been deprecated since
version 3.8 and was removed in 3.11:
https://docs.python.org/3.10/library/asyncio-task.html#generator-based-coroutines

LP: #2031439

049618f... by Adam Dyess on 2022-09-09

the reactive refresh method didn't handle the new remove option added by a prior commit.

https://paste.ubuntu.com/p/PHhQbty6yS/

Reviewed-on: https://code.launchpad.net/~addyess/layer-snap/+git/layer-snap/+merge/429658
Reviewed-by: Barry Price <email address hidden>
Reviewed-by: Kevin W Monroe <email address hidden>

760c200... by Adam Dyess on 2022-09-08

Address issue with refresh now that remove option is avaialble

e13130d... by Adam Dyess on 2022-09-08

Ensure that snap removals occur before snap installs

Ignore the order of the snaps in layer.yaml under the snap layer options, but rely on the presence of the `remove is True` option of each snap to sort the snaps into removals and installs

Process the removals first

Reviewed-on: https://code.launchpad.net/~addyess/layer-snap/+git/layer-snap/+merge/429592
Reviewed-by: Barry Price <email address hidden>

746380e... by Adam Dyess on 2022-09-08

strengthen variable naming

2ec5348... by Adam Dyess on 2022-09-07

ensure flags are set during test_install for accurate call order

126c733... by Adam Dyess on 2022-09-07

ensure that snap removals occur before snap installs

2b6e017... by Adam Dyess on 2022-09-07

add a `remove` option in the snap layer to remove unneeded snaps

Reviewed-on: https://code.launchpad.net/~addyess/layer-snap/+git/layer-snap/+merge/429576
Reviewed-by: Barry Price <email address hidden>