Snap Layer

Merge ~corey.bryant/layer-snap:tenacity into layer-snap:master

  1. Git
  2. lp:~corey.bryant/layer-snap
  3. tenacity
  4. Merge into master
Proposed by Corey Bryant
Status: Merged
Approved by: Haw Loeung
Approved revision: d87f23406335321e0b89877dad21a59471a54512
Merged at revision: c1fb0f7f7de2d21f1c8c74dd7533fefadf2080d8
Proposed branch: ~corey.bryant/layer-snap:tenacity
Merge into: layer-snap:master
Diff against target: 11 lines (+2/-1)
1 file modified
wheelhouse.txt (+2/-1)
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Felipe Reyes (community) Approve
Canonical IS Reviewers Pending
Review via email: mp+449280@code.launchpad.net

Commit message

Only pin tenacity to < 5.0.4 for trusty

Ubuntu Lunar uses python 3.11 where tenacity < 5.0.4 fails with:
"AttributeError: module 'asyncio' has no attribute 'coroutine'"

This is because the @asyncio.coroutine has been deprecated since
version 3.8 and was removed in 3.11:
https://docs.python.org/3.10/library/asyncio-task.html#generator-based-coroutines

LP: #2031439

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Felipe Reyes (freyes) wrote :

LGTM

review: Approve
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision c1fb0f7f7de2d21f1c8c74dd7533fefadf2080d8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/wheelhouse.txt b/wheelhouse.txt
2index f9bf12c..868584d 100644
3--- a/wheelhouse.txt
4+++ b/wheelhouse.txt
5@@ -1,4 +1,5 @@
6 # Newer versions of tenacity rely on `typing` which is in stdlib in
7 # python3.5 but not python3.4. We want to continue to support
8 # python3.4 (Trusty)
9-tenacity<5.0.4
10+tenacity<5.0.4;python_version == '3.4'
11+tenacity;python_version >= '3.5'

Subscribers

People subscribed via source and target branches