Code review comment for lp:~adam-stokes/ubuntu/quantal/gnome-vfs/lp977940-multiarch

Revision history for this message
Adam Stokes (adam-stokes) wrote :

> While I have not done multiarch transitions myself, I read through the various
> documentation and wonder why libgnomevfs2-bin uses 'Multi-Arch: foreign'.
> Shouldn't this be 'Multi-Arch: same' because libgnomevfs2-bin provides
> binaries in /usr/bin (and in debian/control* uses 'Architecture: any' as
> opposed to 'all') and therfore does not meet the "one copy of this package, of
> any architecture, is sufficient to satisfy the needs of the runtime library
> package of every architecture" as per http://wiki.debian.org/Multiarch/Impleme
> ntation#Converting_your_package_for_multiarch?
>
> Otherwise, it looks like there is an approporiate use of Breaks, Replaces,
> Pre-Depends, etc. The files install to the correct places and the pc files
> look ok by visual inspection.

I'm still a little unclear behind the Multi-Arch: same vs. foreign. As I see it we mark the binary package as foreign stating that "The package is not co-installable with itself, but should be allowed to satisfy the dependencies of a package of a different arch from itself."

I'm probably mis-reading the documentation but if someone could verify Jamie's question I can make modifications if necessary.

review: Needs Information

« Back to merge proposal