review-tools

Merge ~adam-collard/review-tools:lp1922030-add-install-mode into review-tools:master

  1. Git
  2. lp:~adam-collard/review-tools
  3. lp1922030-add-install-mode
  4. Merge into master
Proposed by Adam Collard
Status: Merged
Merged at revision: 0602ea8bbc1750d05d3cf71d3b3af094708384c5
Proposed branch: ~adam-collard/review-tools:lp1922030-add-install-mode
Merge into: review-tools:master
Diff against target: 12 lines (+1/-0)
1 file modified
reviewtools/sr_common.py (+1/-0)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+400457@code.launchpad.net

Commit message

LP #1922030: Add install-mode to known optional fields for daemons

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

Thanks, we should also add something to validate this in sr_lint.py ala the existing `check_apps_refresh_mode` and then a unit test as well. I'll see what I can do since I realise this is probably a bit too much to expect from a nice drive-by MR like this - cheers.

Revision history for this message
Alex Murray (alexmurray) wrote :

re validation etc - I have submitted this follow-on MR - https://code.launchpad.net/~alexmurray/review-tools/+git/review-tools/+merge/400620

Revision history for this message
Alex Murray (alexmurray) wrote :

Also I merged this already as 0602ea8bbc1750d05d3cf71d3b3af094708384c5

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/sr_common.py b/reviewtools/sr_common.py
2index ec77a5d..028522a 100644
3--- a/reviewtools/sr_common.py
4+++ b/reviewtools/sr_common.py
5@@ -105,6 +105,7 @@ class SnapReview(Review):
6 "bus-name", # May deprecate: https://forum.snapcraft.io/t/support-for-daemon-dbus/8855/11
7 "daemon",
8 "daemon-scope",
9+ "install-mode",
10 "ports",
11 "post-stop-command",
12 "refresh-mode",

Subscribers

People subscribed via source and target branches

to all changes: