MAAS

Merge ~adam-collard/maas:flaky-profile-name into maas:master

  1. Git
  2. lp:~adam-collard/maas
  3. flaky-profile-name
  4. Merge into master
Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 2b0b97bbc15cfc85a10010f61fb86b7a117aea62
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas:flaky-profile-name
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/tests/maasperf/cli/conftest.py (+1/-1)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Alberto Donato (community) Approve
Review via email: mp+443651@code.launchpad.net

Commit message

fix: flaky maas_user profile name, use a hard-coded name

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b flaky-profile-name lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2606/console
COMMIT: 3a7cb1f465005aacc64a728ad3706ebd7cbc691f

review: Needs Fixing
~adam-collard/maas:flaky-profile-name updated
2b0b97b... by Adam Collard

ack's suggestion: use a fixed profile name

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b flaky-profile-name lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: eefb72a0389941bce157c9b59616e298f57c242d

review: Approve
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b flaky-profile-name lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 2b0b97bbc15cfc85a10010f61fb86b7a117aea62

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/tests/maasperf/cli/conftest.py b/src/tests/maasperf/cli/conftest.py
2index 79aeba8..883d3a2 100644
3--- a/src/tests/maasperf/cli/conftest.py
4+++ b/src/tests/maasperf/cli/conftest.py
5@@ -28,7 +28,7 @@ def cli_profile(maas_user):
6 handler["uri"] = "http://localhost:5240/MAAS" + handler["path"]
7
8 return {
9- "name": maas_user.username,
10+ "name": "localmaas",
11 "url": "http://localhost:5240/MAAS",
12 "credentials": [token.consumer.key, token.key, token.secret],
13 "description": description,

Subscribers

People subscribed via source and target branches