Merge ~adam-collard/maas:no-double-permission-checking into maas:master

[Adam Collard]

fix: don't double check permissions in compile_node_actions

is_actionable() already checks is_permitted(); no need to double check it.

[Christian Grabowski (cgrabowski)]

+1

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b no-double-permission-checking lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 2d5b6049c940bb86dd74726d6a3ae6e810da972f

review: Approve

diff --git a/src/maasserver/node_action.py b/src/maasserver/node_action.py
index 0049c1b..fd989e7 100644
--- a/src/maasserver/node_action.py
+++ b/src/maasserver/node_action.py
@@ -1117,7 +1117,5 @@ def compile_node_actions(node, user, request=None, classes=ACTION_CLASSES):
     """
     actions = (action_class(node, user, request) for action_class in classes)
     return OrderedDict(
-        (action.name, action)
-        for action in actions
-        if action.is_actionable() and action.is_permitted()
+        (action.name, action) for action in actions if action.is_actionable()
     )