Merge ~adam-collard/maas:pod-discovery-error into maas:master

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: bc7120d951c86776ef72b561b37117a705fd789a
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas:pod-discovery-error
Merge into: maas:master
Diff against target: 42 lines (+4/-2)
2 files modified
src/maasserver/tests/test_vmhost.py (+2/-0)
src/maasserver/vmhost.py (+2/-2)
Reviewer Review Type Date Requested Status
MAAS Lander Needs Fixing
Alberto Donato (community) Approve
Review via email: mp+431493@code.launchpad.net

Commit message

PodProblem raised in discovery includes original exception

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b pod-discovery-error lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/1009/consoleText
COMMIT: bc7120d951c86776ef72b561b37117a705fd789a

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/tests/test_vmhost.py b/src/maasserver/tests/test_vmhost.py
2index 996e3a1..3db3667 100644
3--- a/src/maasserver/tests/test_vmhost.py
4+++ b/src/maasserver/tests/test_vmhost.py
5@@ -199,6 +199,7 @@ class TestDiscoverAndSyncVMHost(MAASServerTestCase):
6 factory.make_User(),
7 )
8 self.assertEqual(str(exc), str(error))
9+ self.assertIs(error.__cause__, exc)
10
11
12 class TestDiscoverAndSyncVMHostAsync(MAASTransactionServerTestCase):
13@@ -274,6 +275,7 @@ class TestDiscoverAndSyncVMHostAsync(MAASTransactionServerTestCase):
14 except Exception as error:
15 self.assertIsInstance(error, PodProblem)
16 self.assertEqual(str(exc), str(error))
17+ self.assertIs(error.__cause__, exc)
18 else:
19 self.fail("No exception raised")
20
21diff --git a/src/maasserver/vmhost.py b/src/maasserver/vmhost.py
22index da4e18e..9ee1f73 100644
23--- a/src/maasserver/vmhost.py
24+++ b/src/maasserver/vmhost.py
25@@ -82,7 +82,7 @@ def discover_and_sync_vmhost(vmhost, user):
26 )
27 discovered_pod = get_best_discovered_result(discovered)
28 except Exception as error:
29- raise PodProblem(str(error))
30+ raise PodProblem(str(error)) from error
31
32 if discovered_pod is None:
33 raise PodProblem(
34@@ -118,7 +118,7 @@ async def discover_and_sync_vmhost_async(vmhost, user):
35 )
36 discovered_pod = get_best_discovered_result(discovered)
37 except Exception as error:
38- raise PodProblem(str(error))
39+ raise PodProblem(str(error)) from error
40
41 if discovered_pod is None:
42 raise PodProblem(

Subscribers

People subscribed via source and target branches