MAAS

Merge ~adam-collard/maas:flaky-test-keys-1990873 into maas:master

  1. Git
  2. lp:~adam-collard/maas
  3. flaky-test-keys-1990873
  4. Merge into master
Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: c8398518461f6ca736289f88baf765386bf673bd
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas:flaky-test-keys-1990873
Merge into: maas:master
Diff against target: 45 lines (+5/-1)
1 file modified
src/maasserver/utils/tests/test_keys.py (+5/-1)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Alexsander de Souza Approve
Review via email: mp+430494@code.launchpad.net

Commit message

LP:1990873 Add deadline=None to hypothesis tests

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b flaky-test-keys-1990873 lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/787/consoleText
COMMIT: c8398518461f6ca736289f88baf765386bf673bd

review: Needs Fixing
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

+1

review: Approve
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b flaky-test-keys-1990873 lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: c8398518461f6ca736289f88baf765386bf673bd

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/utils/tests/test_keys.py b/src/maasserver/utils/tests/test_keys.py
2index d3689e3..eda783d 100644
3--- a/src/maasserver/utils/tests/test_keys.py
4+++ b/src/maasserver/utils/tests/test_keys.py
5@@ -6,7 +6,7 @@
6
7 import http
8
9-from hypothesis import given
10+from hypothesis import given, settings
11 from hypothesis.strategies import sampled_from
12 import requests as requests_module
13 from testtools.matchers import Equals
14@@ -49,6 +49,7 @@ class TestKeys(MAASServerTestCase):
15 proxies = get_proxies()
16 self.assertIsNone(proxies)
17
18+ @settings(deadline=None)
19 @given(sampled_from([KEYS_PROTOCOL_TYPE.LP, KEYS_PROTOCOL_TYPE.GH]))
20 def test_get_protocol_keys_attempts_retrival(self, protocol):
21 auth_id = factory.make_name("auth_id")
22@@ -59,6 +60,7 @@ class TestKeys(MAASServerTestCase):
23 get_protocol_keys(protocol, auth_id)
24 self.assertThat(mock_get_keys, MockCalledOnceWith(auth_id))
25
26+ @settings(deadline=None)
27 @given(sampled_from([KEYS_PROTOCOL_TYPE.LP, KEYS_PROTOCOL_TYPE.GH]))
28 def test_get_protocol_keys_crashes_on_no_keys(self, protocol):
29 auth_id = factory.make_name("auth_id")
30@@ -85,6 +87,7 @@ class TestKeys(MAASServerTestCase):
31 keys, Equals([key for key in key_string.splitlines() if key])
32 )
33
34+ @settings(deadline=None)
35 @given(sampled_from([http.HTTPStatus.NOT_FOUND, http.HTTPStatus.GONE]))
36 def test_get_launchpad_crashes_for_user_not_found(self, error):
37 auth_id = factory.make_name("auth_id")
38@@ -104,6 +107,7 @@ class TestKeys(MAASServerTestCase):
39 keys, Equals([data["key"] for data in key_string if "key" in data])
40 )
41
42+ @settings(deadline=None)
43 @given(sampled_from([http.HTTPStatus.NOT_FOUND, http.HTTPStatus.GONE]))
44 def test_get_github_crashes_for_user_not_found(self, error):
45 auth_id = factory.make_name("auth_id")

Subscribers

People subscribed via source and target branches