Merge ~adam-collard/maas/+git/maas-release-tools:assign-bugs into ~maas-committers/maas/+git/maas-release-tools:main

[Adam Collard]

Add assign-bugs-to-milestone script

[Christian Grabowski (cgrabowski)]

+1

review: Approve

diff --git a/maas_release_tools/actions.py b/maas_release_tools/actions.py
index 7d6d840..8a0c605 100644
--- a/maas_release_tools/actions.py
+++ b/maas_release_tools/actions.py
@@ -17,6 +17,12 @@ class Actions:
         action = getattr(self, action_name)
         return action()
 
+    def assign_bugs_to_milestone(self):
+        """Assign bugs to a milestone, re-opening and closing as necessary"""
+        self.lp_actions.assign_bugs_to_milestone(
+            self.args.bugs, self.args.milestone
+        )
+
     def move_done_bugs(self):
         """Move completed bugs across milestones."""
         self.lp_actions.move_done_bugs(self.args.origin, self.args.dest)
diff --git a/maas_release_tools/launchpad.py b/maas_release_tools/launchpad.py
index 135a1d3..25d7db7 100644
--- a/maas_release_tools/launchpad.py
+++ b/maas_release_tools/launchpad.py
@@ -1,5 +1,6 @@
 """Interact with Launchpad API."""
 
+from contextlib import contextmanager
 from datetime import datetime
 import logging
 from pathlib import Path
@@ -52,6 +53,27 @@ class LaunchpadActions:
         dest = self._get_milestone(dest_milestone)
         self._move_bugs(UNFINISHED_BUGS, origin, dest, dry_run=self.dry_run)
 
+    def assign_bugs_to_milestone(
+        self, bugs: list[str], milestone_name: str
+    ) -> None:
+        """Assign bugs to a milestone, re-opening and closing as necessary."""
+        with self._active_milestone(milestone_name) as milestone:
+            for bug_number in bugs:
+                bug = self.lp.bugs[bug_number]
+                for task in bug.bug_tasks:
+                    if task.target == self._project:
+                        self.logger.info(
+                            f"assigning bug {bug_number} to milestone {milestone.name}"
+                        )
+                        task.milestone = milestone
+                        if not self.dry_run:
+                            task.lp_save()
+                        break
+                else:
+                    self.logger.error(
+                        f"No task found for {bug_number} on project {self._project}"
+                    )
+
     def release_milestone(self, name: str):
         """Release a milestone marking finished bug as released."""
         milestone = self._get_milestone(name)
@@ -65,8 +87,8 @@ class LaunchpadActions:
                 bug_task.lp_save()
 
         self.logger.info(f"closing milestone {milestone.name}")
+        milestone.is_active = False
         if not self.dry_run:
-            milestone.is_active = False
             milestone.lp_save()
 
         if milestone.release is None:
@@ -79,7 +101,7 @@ class LaunchpadActions:
     def _get_client(
         self, credentials_file: Optional[Path] = None
     ) -> Launchpad:
-        """Return a Launchopad API client."""
+        """Return a Launchpad API client."""
         kwargs = {
             "service_root": "https://api.launchpad.net",
             "version": "devel",
@@ -94,6 +116,24 @@ class LaunchpadActions:
             raise UnknownLaunchpadEntry("milestone", name)
         return milestone
 
+    @contextmanager
+    def _active_milestone(self, name):
+        """Allows callers to temporarily open a milestone."""
+        milestone = self._get_milestone(name)
+        was_active = milestone.is_active
+        if not was_active:
+            self.logger.info(f"marking milestone {name} as temporarily active")
+        if not self.dry_run:
+            milestone.is_active = True
+            if not was_active:
+                milestone.lp_save()
+        yield milestone
+        if not was_active:
+            self.logger.info(f"marking milestone {name} inactive")
+            milestone.is_active = False
+            if not self.dry_run:
+                milestone.lp_save()
+
     def _move_bugs(
         self,
         statuses: Sequence[str],
@@ -106,6 +146,6 @@ class LaunchpadActions:
             self.logger.info(
                 f"retargeting bug {bug_task.bug.id}: {bug_task.bug.title}"
             )
+            bug_task.milestone = dest_milestone
             if not dry_run:
-                bug_task.milestone = dest_milestone
                 bug_task.lp_save()
diff --git a/maas_release_tools/scripts/release_manage.py b/maas_release_tools/scripts/release_manage.py
index 2954476..c22c31e 100644
--- a/maas_release_tools/scripts/release_manage.py
+++ b/maas_release_tools/scripts/release_manage.py
@@ -37,13 +37,20 @@ def parse_args():
         default=False,
         help="don't actually perform actions",
     )
-    parser.add_argument("project", help="the project manage releases for")
+    parser.add_argument("project", help="the project to manage releases for")
 
     subparsers = parser.add_subparsers(
         metavar="ACTION", dest="action", help="action to perform"
     )
     subparsers.required = True
 
+    assign_bugs = subparsers.add_parser(
+        "assign-bugs-to-milestone",
+        help=Actions.assign_bugs_to_milestone.__doc__,
+    )
+    assign_bugs.add_argument("milestone", help="the milestone to assign")
+    assign_bugs.add_argument("bugs", nargs="+", help="the bugs to assign")
+
     move_done_bugs = subparsers.add_parser(
         "move-done-bugs", help="move done bugs from a milestone to another"
     )