Merge ~adam-collard/maas/+git/maas-release-tools:dont-rerelease into ~maas-committers/maas/+git/maas-release-tools:main

[Adam Collard]

Don't try to re-release a milestone that's already released.

Signed-off-by: Adam Collard <email address hidden>

[Alberto Donato (ack)]

nice, +1

minor suggestion inline

review: Approve

diff --git a/maas_release_tools/launchpad.py b/maas_release_tools/launchpad.py
index 7ebba34..135a1d3 100644
--- a/maas_release_tools/launchpad.py
+++ b/maas_release_tools/launchpad.py
@@ -69,9 +69,12 @@ class LaunchpadActions:
             milestone.is_active = False
             milestone.lp_save()
 
-        self.logger.info(f"releasing milestone {milestone.name}")
-        if not self.dry_run:
-            milestone.createProductRelease(date_released=datetime.utcnow())
+        if milestone.release is None:
+            self.logger.info(f"releasing milestone {milestone.name}")
+            if not self.dry_run:
+                milestone.createProductRelease(date_released=datetime.utcnow())
+        else:
+            self.logger.info(f"milestone {milestone.name} already released")
 
     def _get_client(
         self, credentials_file: Optional[Path] = None