Merge ~adam-collard/maas-ci/+git/system-tests:output-file-filter-envs into ~maas-committers/maas-ci/+git/system-tests:master

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 0c9841719007ae9707d8bdcdb5466a98a0be26f6
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas-ci/+git/system-tests:output-file-filter-envs
Merge into: ~maas-committers/maas-ci/+git/system-tests:master
Diff against target: 30 lines (+5/-2)
1 file modified
utils/filter_envs.py (+5/-2)
Reviewer Review Type Date Requested Status
Thorsten Merten Approve
MAAS Lander Approve
Review via email: mp+434515@code.launchpad.net

Commit message

Add --output-file option to filter_envs

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b output-file-filter-envs lp:~adam-collard/maas-ci/+git/system-tests into -b master lp:~maas-committers/maas-ci/+git/system-tests

STATUS: SUCCESS
COMMIT: 0c9841719007ae9707d8bdcdb5466a98a0be26f6

review: Approve
Revision history for this message
Thorsten Merten (thorsten-merten) wrote :

+1 (also for removing that annoying blank line :) ).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/utils/filter_envs.py b/utils/filter_envs.py
2index df3976a..05d2d0f 100644
3--- a/utils/filter_envs.py
4+++ b/utils/filter_envs.py
5@@ -4,7 +4,6 @@ import sys
6
7
8 def main(argv: list[str]) -> int:
9-
10 parser = argparse.ArgumentParser()
11 parser.add_argument(
12 "desired_envs",
13@@ -12,6 +11,10 @@ def main(argv: list[str]) -> int:
14 help="list of desired envs separated by ',' (ie: vm1,vm2,opelt)",
15 )
16
17+ parser.add_argument(
18+ "--output-file", type=argparse.FileType("w"), default=sys.stdout
19+ )
20+
21 args = parser.parse_args(argv)
22
23 valid_envs_raw = subprocess.check_output(["tox", "-a"], encoding="utf8")
24@@ -19,7 +22,7 @@ def main(argv: list[str]) -> int:
25
26 desired_envs = set(args.desired_envs.split(","))
27
28- print(",".join(desired_envs & valid_envs))
29+ print(",".join(desired_envs & valid_envs), file=args.output_file)
30 return 0
31
32

Subscribers

People subscribed via source and target branches

to all changes: