Code review comment for lp:~adam-collard/landscape-client/config-file-sysinfo

Revision history for this message
Geoff Teale (tealeg) wrote :

+1 Approve

With regards to Bjorn's suggestion above - it seem quite good, but I'm slightly concerned that we wouldn't append an error if os.path.isfile returns false for a filename in self.default_config_filenames. That should be done if you choose to adopt Bjorn's code.

review: Approve

« Back to merge proposal