Code review comment for lp:~adam-collard/charms/trusty/swift-storage/add-pause-resume-actions

Hi. Kicking in with some hopefully helpful hints. I see the proposed test is failing when trying to confirm a system service that doesn't appear to be present at a particular release combo.

Since the basic_deployment.py set of tests is expected to pass for all supported release combos, each test_ method may need to use release detection logic as needed. In some cases, openstack components have shifted options, sections, etc., in conf files. In other cases, some system services may or may not be present across that entire timeline. There was particularly a lot of upstream shifting-around introduced at >= Kilo ... and < Icehouse.

As a usage example, the heat amulet test detects and checks things slightly differently here:
http://bazaar.launchpad.net/~openstack-charmers/charms/trusty/heat/next/view/head:/tests/basic_deployment.py#L313

Which ultimately uses this for comparison:
http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/openstack/amulet/deployment.py#L109