> Thanks for your branch. On principle it looks good, but some tests fail and > others clutter stdout/stderr on "make test".
Thanks for the review. Sorry for not running the full test suite before proposing.
The extra tests I added exposed existing failures in the amulet utils when running under Python 3. I've fixed those, and added code to capture stdout.
> I'm going to have to mark this as need fixing until "make test" produces a > clean (and passing) output.
Please take another look, believed to have been fixed now!
« Back to merge proposal
> Thanks for your branch. On principle it looks good, but some tests fail and
> others clutter stdout/stderr on "make test".
Thanks for the review. Sorry for not running the full test suite before proposing.
The extra tests I added exposed existing failures in the amulet utils when running under Python 3. I've fixed those, and added code to capture stdout.
> I'm going to have to mark this as need fixing until "make test" produces a
> clean (and passing) output.
Please take another look, believed to have been fixed now!