Code review comment for lp:~adam-barancsuk/unity/fix-740515

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I can see how this implementation fixes the problem, but there are some weird things that you do in the implementation that don't make sense to me.

First of all, there is a hardcoding of the view height to 24, which could be a bad thing if we ever made the panel larger for a11y reasons. Also, you're stacking the widget from the top of the view container down, which means there's essentially going to be a larger "dead area" at the bottom of the panel.

I think a better idea here would be to stack the object in the center of the panel (that way it grows from the center if the panel was to get larger) and set it's view height to the height of the panel. That way, whenever we get an input event there, it will always go to the button.

review: Needs Information

« Back to merge proposal