Code review comment for lp:~acsone-openerp/hr-timesheet/migration_hr_timesheet_taskV7

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello,

There are some cleaning that could be done in .py files

-> Remove osv.memory
import orm and use orm.TransiantModel instead

from openerp.osv import osv, orm

class MyWizard(orm.TransientModel):

-> Remove useless class instantiations
like on l516 remove the "ProjectTask()".

And in XML, it would better to use simpler relative xpath when possible
like l535 could be "///field[@name='work_ids']" (if it had been done previously the change wouldn't have been needed)

Thanks

review: Needs Fixing (code)

« Back to merge proposal