Code review comment for lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
review:
Approve
(code review, no test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Thanks for the changes!
That's a common issue with tests, when a module adds a NOT NULL constraint on a column, other modules tests do not fill this required field and fails. But I don't think that's something we can avoid.
I think that the most important is to have success results when the module is installed alone.
Looks good to me