Merge lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi into lp:banking-addons/bank-statement-reconcile-70
Proposed by
Laurent Mignon (Acsone)
Status: | Merged |
---|---|
Merged at revision: | 146 |
Proposed branch: | lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi |
Merge into: | lp:banking-addons/bank-statement-reconcile-70 |
Diff against target: |
185 lines (+137/-11) 4 files modified
account_statement_base_import/data/statement.csv (+1/-1) account_statement_base_import/statement.py (+4/-10) account_statement_base_import/tests/__init__.py (+27/-0) account_statement_base_import/tests/test_base_import.py (+105/-0) |
To merge this branch: | bzr merge lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joël Grand-Guillaume @ camptocamp | code review + test | Approve | |
Yannick Vaucher @ Camptocamp | code review, no test | Approve | |
Guewen Baconnier @ Camptocamp | code review | Approve | |
Review via email: mp+217467@code.launchpad.net |
Description of the change
Remove the default value to False on account_id in account_
I've the feeling that it's the responsibility of the parser to provide an blank/None account_id if the one provided by the base module 'account_
Regards,
lmi
To post a comment you must log in.
LGTM,
Thanks