lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-bug-1313689-lmi

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:banking-addons/bank-statement-reconcile-70 at revision 146

Joël Grand-Guillaume @ camptocamp: Approve (code review + test) on 2014-05-05

Yannick Vaucher @ Camptocamp: Approve (code review, no test) on 2014-05-05

Guewen Baconnier @ Camptocamp: Approve (code review) on 2014-05-05

Diff: 185 lines (+137/-11)

4 files modified

account_statement_base_import/data/statement.csv (+1/-1)
account_statement_base_import/statement.py (+4/-10)
account_statement_base_import/tests/__init__.py (+27/-0)
account_statement_base_import/tests/test_base_import.py (+105/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1313689: [7.0] account_statement_base_import: default account_id to false (mp:197755) breaks import of line without account_id

High

Fix Released

Link a bug report

Related blueprints

146. By Laurent Mignon (Acsone) on 2014-04-28

[FIX] lp:1313689
Remove default value to False for account_id since it breaks existing code. It's the responsability of the parser to fill a blank/None account_id in the statement_line values if the default one provided by account_statement_ext does not apply to the expected behavior

145. By Laurent Mignon (Acsone) on 2014-04-28

PEP-8

144. By Guewen Baconnier @ Camptocamp on 2014-04-27

[FIX] too many characters are escaped, leading to an 'invalid regular expression: invalid escape \ sequence' error.

143. By Sébastien BEAU - http://www.akretion.com on 2014-04-25

[REF] account_id is not anymore mandatory for creating a bank statement line. Still mandatory for the validation

142. By Launchpad Translations on behalf of banking-addons-team on 2014-04-22

Launchpad automatic translations update.

141. By Guewen Baconnier @ Camptocamp on 2014-04-14

Improvement around the Transaction IDs modules
==============================================

This proposal aims to improve the modules using transaction ids, I will start
by summarizing what are they used for, then what are the existing problems and
what changes I propose.

Transaction IDs?
----------------

The transaction IDs are a technical reference for a move line. They are to
differentiate from the usual reference that are a reference for humans firstly
(more about that here [0]). Usually, the transaction IDs are defined by
external systems such as payment gateways and are a way to streamline the
reconciliations between the invoices, bank statements...

Changes
-------

1) account_move_line.transaction_ref is defined in 'account_advanced_reconcile_transaction_ref' which adds a reconciliation method with transaction id.
It makes much sense to add the field in 'base_transaction_id' so we can use the field in other modules such as the bank statement completion modules. It is a pity that the field on the invoice and the sale order is 'transaction_id' and in move lines 'transaction_ref' but I prefer to keep the backward-compatibility.

So I moved these things from 'account_advanced_reconcile_transaction_ref' to 'base_transaction_id'

2) In account_advanced_reconcile_transaction_ref there is an inherit of the bank statement that copies the line's ref in the move line's transaction_id. I think this is a mismatch between the ref and the transaction_id that we have to avoid. In fact, only the transaction id of the statement lines should be copied if any, or left empty if the statement line has no transaction id.

3) A consequence of the change 2) is that the automatic reconcile from transaction ref will no longer work for those not using the transaction ids in the bank statement but only the ref. So I added a new reconciliation rule that matches 'ref' vs 'transaction id'. The only drawback is that they will need to change their configuration, but at least the rules will be clear on their intentions.

4) completion rules: 'base_transaction_id' adds a transaction_id on sales order and invoices. There is actually a completion rule that searches the bank statement information from a matching invoice with the same transaction_id. I added the same rule that searches for an invoice with the same transaction id. This is the logical continuation and a good complement when an invoice / refund was not generated by a sales order and we still need to autocomplete the bank statement.

[0] https://code.launchpad.net/~camptocamp/banking-addons/7.0-bank-statement-reconcile-account_invoice_reference/+merge/202689

140. By Launchpad Translations on behalf of banking-addons-team on 2014-04-03

Launchpad automatic translations update.

139. By Joël Grand-Guillaume @ camptocamp on 2014-04-02

[IMP] Add buttons to open unreconciled and partially reconciled items from a profile to easy the verification and controlling
  [IMP] Add the number of lines in completion log to let the user know if some hasn't been auto-completed (e.g. 332/335 line compelted)
  [IMP] Add a group by bank statement in journal items search view to ease the reconciliation

138. By Leonardo Pistone on 2014-04-02

[fix] account_statement_base_import: add all missing default values to the statement line.
This has to be done manually because the module uses sql trickery

137. By Launchpad Translations on behalf of banking-addons-team on 2014-03-22

Launchpad automatic translations update.