Merge lp:~acsone-openerp/banking-addons/account_statement_bankaccount_completion_no_auto_install into lp:banking-addons/bank-statement-reconcile-70

Proposed by Stéphane Bidoul (Acsone)
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 115
Merged at revision: 130
Proposed branch: lp:~acsone-openerp/banking-addons/account_statement_bankaccount_completion_no_auto_install
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 46 lines (+9/-10)
2 files modified
account_statement_bankaccount_completion/__openerp__.py (+8/-9)
account_statement_bankaccount_completion/data.xml (+1/-1)
To merge this branch: bzr merge lp:~acsone-openerp/banking-addons/account_statement_bankaccount_completion_no_auto_install
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Laurent Mignon (Acsone) (community) code review Approve
Review via email: mp+202221@code.launchpad.net

Description of the change

Do not auto_install account_statement_bankaccount_completion.

Plus a bit of pep8 and cleanup.

To post a comment you must log in.
Revision history for this message
Laurent Mignon (Acsone) (lmi) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_statement_bankaccount_completion/__openerp__.py'
--- account_statement_bankaccount_completion/__openerp__.py 2013-09-12 09:05:01 +0000
+++ account_statement_bankaccount_completion/__openerp__.py 2014-01-19 17:40:45 +0000
@@ -29,21 +29,20 @@
29 'account_statement_base_completion',29 'account_statement_base_completion',
30 ],30 ],
31 'description': """31 'description': """
32 Add a completion method based on the partner bank account number provided by the bank/office.32 Add a completion method based on the partner bank account number
33 provided by the bank/office.
3334
34 Completion will look in the partner with that bank account number to match the partner, 35 Completion will look in the partner with that bank account number
35 then it will fill in the bank statement line with it to ease the reconciliation.36 to match the partner, then it will fill in the bank statement line
37 with it to ease the reconciliation.
3638
37 """,39 """,
38 'website': 'http://www.acsone.eu',40 'website': 'http://www.acsone.eu',
39 'init_xml': [],41 'data': [
40 'update_xml': [
41 "data.xml",42 "data.xml",
42 ],43 ],
43 'demo_xml': [],44 'demo': [],
44 'test': [],
45 'installable': True,45 'installable': True,
46 'images': [],46 'auto_install': False,
47 'auto_install': True,
48 'license': 'AGPL-3',47 'license': 'AGPL-3',
49 }48 }
5049
=== modified file 'account_statement_bankaccount_completion/data.xml'
--- account_statement_bankaccount_completion/data.xml 2013-08-26 12:19:09 +0000
+++ account_statement_bankaccount_completion/data.xml 2014-01-19 17:40:45 +0000
@@ -3,7 +3,7 @@
3<data noupdate="1">3<data noupdate="1">
44
5 <record id="bank_statement_completion_rule_10" model="account.statement.completion.rule">5 <record id="bank_statement_completion_rule_10" model="account.statement.completion.rule">
6 <field name="name">Match from bank account number (Nomal or IBAN))</field>6 <field name="name">Match from bank account number (Normal or IBAN))</field>
7 <field name="sequence">10</field>7 <field name="sequence">10</field>
8 <field name="function_to_call">get_from_bank_account</field>8 <field name="function_to_call">get_from_bank_account</field>
9 </record>9 </record>

Subscribers

People subscribed via source and target branches