Merge lp:~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi into lp:anybox.recipe.openerp

[Laurent Mignon (Acsone)]

[FIX] lp:1317269 Set the path to the main script source file (openerp-server) as first item in sys.argv so that the server can use this argument to know where is this main script

[Georges Racinet (gracinet)]

Bonjour,

je suis off cette semaine, mais je regarderai la semaine prochaine.

J'en profite pour te dire qu'on devrait reparler du sprint buildbot…

On 05/08/2014 08:37 AM, Laurent Mignon (Acsone) wrote:
> Laurent Mignon (Acsone) has proposed merging lp:~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi into lp:anybox.recipe.openerp.
>
> Requested reviews:
> Anybox (anybox)
> Related bugs:
> Bug #1317269 in OpenERP buildout recipe: "OSError: [Errno 2] Aucun fichier ou dossier de ce type"
> https://bugs.launchpad.net/anybox.recipe.openerp/+bug/1317269
>
> For more details, see:
> https://code.launchpad.net/~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi/+merge/218744
>
> [FIX] lp:1317269 Set the path to the main script source file (openerp-server) as first item in sys.argv so that the server can use this argument to know where is this main script

--
Georges Racinet
Anybox SAS, http://anybox.fr
Bureau: 09 72 39 50 97 / 09 72 39 13 06
Portable: 06 51 32 07 27
GPG: 0x33AB0A35, sur serveurs publics

[Laurent Mignon (Acsone) (lmi)]

Pas de souci.
Pour le sprint buildout, ce serait une bonne chose et avec plaisir.
J'ai vu que vous aviez un talk aux OpenDays sur le sujet. De notre côté on
présentera le travail sur pydev comme une extension à votre recipe. (je
dois encore nettoyer tout mon brol pour en en faire un egg qui dépende de
anybox.recipe.openerp)

A bientôt

lmi

On Thu, May 8, 2014 at 2:54 PM, Georges Racinet <email address hidden> wrote:

> Bonjour,
>
> je suis off cette semaine, mais je regarderai la semaine prochaine.
>
> J'en profite pour te dire qu'on devrait reparler du sprint buildbot…
>
> On 05/08/2014 08:37 AM, Laurent Mignon (Acsone) wrote:
> > Laurent Mignon (Acsone) has proposed merging
> lp:~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi into
> lp:anybox.recipe.openerp.
> >
> > Requested reviews:
> > Anybox (anybox)
> > Related bugs:
> > Bug #1317269 in OpenERP buildout recipe: "OSError: [Errno 2] Aucun
> fichier ou dossier de ce type"
> > https://bugs.launchpad.net/anybox.recipe.openerp/+bug/1317269
> >
> > For more details, see:
> >
> https://code.launchpad.net/~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi/+merge/218744
> >
> > [FIX] lp:1317269 Set the path to the main script source file
> (openerp-server) as first item in sys.argv so that the server can use this
> argument to know where is this main script
>
>
> --
> Georges Racinet
> Anybox SAS, http://anybox.fr
> Bureau: 09 72 39 50 97 / 09 72 39 13 06
> Portable: 06 51 32 07 27
> GPG: 0x33AB0A35, sur serveurs publics
>
>
>
> https://code.launchpad.net/~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi/+merge/218744
> You proposed lp:~acsone-openerp/anybox.recipe.openerp/1.8-bug-1317269-lmi
> for merging.
>

--
*Laurent Mignon*
*Senior Software Engineer*

*Tel : [phone]*
*Fax : [phone]*
*Gsm : [phone]*
*Email: <email address hidden> <email address hidden>*

*Acsone SA, Succursale de Luxembourg*
*22, Zone industrielle*
*L-8287 Kehlen, Luxembourg*
*www.acsone.eu <http://www.acsone.eu>*

[Georges Racinet (gracinet)]

Good for stable branch (seems harmless enough)

I felt compelled to check that this does introduce regression for v7 (no obvious problem)

review: Approve

=== modified file 'CHANGES.rst'
--- CHANGES.rst	2014-04-19 17:30:50 +0000
+++ CHANGES.rst	2014-05-08 06:27:48 +0000
@@ -14,7 +14,8 @@
 
 1.8.4 (unreleased)
 ------------------
-- 
+- launchpad #1317269: [v8] OpenERP server can't start in a multi workers mode
+- launchpad #1314566: [v8] OpenERP scripts & interpreter can't load db
 
 1.8.3 (2014-04-19)
 ------------------

=== modified file 'anybox/recipe/openerp/runtime/session.py'
--- anybox/recipe/openerp/runtime/session.py	2013-12-29 18:05:04 +0000
+++ anybox/recipe/openerp/runtime/session.py	2014-05-08 06:27:48 +0000
@@ -261,7 +261,15 @@
         self.registry('ir.module.module').update_list(self.cr, self.uid)
 
     def init_cursor(self):
-        self.cr = self._registry.db.cursor()
+        db = getattr(self._registry, 'db', None)
+        if db is None:  # current trunk (future v8)
+            self.cr = self._registry.cursor()
+        else:
+            # In OpenERP < 8, Registry.cursor() object is
+            # a context manager providing auto closing,
+            # but we don't want to control the whole lifespan
+            # of the cursor.
+            self.cr = db.cursor()
 
     def registry(self, model):
         """Lookup model by name and return a ready-to-work instance."""

=== modified file 'anybox/recipe/openerp/runtime/start_openerp.py'
--- anybox/recipe/openerp/runtime/start_openerp.py	2013-10-29 08:33:52 +0000
+++ anybox/recipe/openerp/runtime/start_openerp.py	2014-05-08 06:27:48 +0000
@@ -62,6 +62,7 @@
     glob = globals()
     glob['__name__'] = '__main__'
     glob['__file__'] = starter
+    sys.argv[0] = starter
     try:
         execfile(starter, globals())
     except SystemExit as exc: