Code review comment for lp:~acoconut/systers/flexible_essays

Revision history for this message
Robin J (robin-jeffries) wrote :

in DlistUtils.py
 if DEBUG_MODE:
    syslog('info', 'DlistUtils(get_answer):Executing query:\n%s', command)

but command is no longer defined, right? I think you removed the wrong syslog statement.

Do you have a place where you use get_answer() yet? I'm trying to figure out how you are going to know the form_question_id

put
 syslog('info', "Result %s", result)
under an if DEBUG_MODE: guard -- you don't want to be filling up the info log with all these statements every time someone signs up.

Sorry to have missed some of these earlier -- it's hard to see everything going on in a review.

« Back to merge proposal