Code review comment for lp:~acoconut/systers/flexible_essays

Revision history for this message
Robin J (robin-jeffries) wrote :

On Sat, Jul 28, 2012 at 7:25 AM, Ana Cutillas <email address hidden> wrote:

>
> >
> > formQuestionID =
> > self.store.find(FormQuestion).max(FormQuestion.form_question_id)
> >
> >
> I am saving in formQuestionID the return value from storing which is the
> number that has been autoupdated. Does that make sense?
>

Yes, I think my problem was that I wasn't looking at the left side because
of the line break. My bad.

>
> >
> > I was refering to the line in rmlist
> > DlistUtils.remove_dlist(listname)
> > (which, taken with the lines above it, seems to be that you encapsulated
> > those lines into a method, but I didn't see it in the changes to
> > DlistUtils.py
> >
> >
> > I haven't touched rmlist at all. So I don't know how that changed :-/
>

OK, looks like someone else did this, but it's not in the repo. Next year
we will start everyone with a clean slate and eliminate these issues.

« Back to merge proposal