Code review comment for lp:~acoconut/systers/flexible_essays

Revision history for this message
Robin J (robin-jeffries) wrote :

Just read your comments. Sorry.

1. You are telling me you have no control of whether the essay comes in as a list or a string. OK (at least I don't have the knowledge to override it)

2. version ought to be stored with the question. You would update the version whenever someone edits the question rather than replaces it (I would think an edit would be one of several types
    -wording change
    - answer type

So I would start when someone creates a question as version 1, and then when it is edited, that gets incremented. So it's part of the definition of the question (like the question text), and you don't need to store it in the pck file (every question could be a different version level.).

I think the big reason you don't understand version yet is that you haven't figured out what you are going to do with it. If you were to sketch out what the UI is going to look like for the administrator, when they go to approve these folks, and then think about what you want it to look like if you have two people with a) different versions of the same question, b) different questions, that might help you figure out where you want to keep the version number.

« Back to merge proposal