Code review comment for lp:~acoconut/systers/flexible_essays
Revision history for this message
| Robin J (robin-jeffries) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
OK, we are definitely making progress. Some questions and one change request:
- what do fields 3 and 4 mean in your data structure (0, and 'bottom' for the checkbox?)
- I'm not sure what you are doing for the checkbox (because I don't really understand that html). The part that confuses me is that you are using question[1] there twice. One part I think you are naming the checkbox, but why the second time? It seems to also be the value?
My requested change is that questions is too similar to mlist.questions. I think the code will be much easier for someone else to read if you change that to something like html_questions