Code review comment for ~ack/ubuntu/+source/maas:transitional-snap

Revision history for this message
Alberto Donato (ack) wrote :

> This looks ok I guess. I'm not sure if the apt-mark call in the postinst works
> - I don't think it should, apt should probably do some locking there to
> prevent it from being called while installing, as it writes that file after
> the install is done, but apart from that, it seems good to go.

I wasn't sure if that's allowed (or best practice) but it does seem to work fine.

I wonder if there's another way to do that without calling apt-mark.

« Back to merge proposal