Code review comment for ~ack/ubuntu/+source/maas:transitional-snap

Revision history for this message
Julian Andres Klode (juliank) wrote :

This looks ok I guess. I'm not sure if the apt-mark call in the postinst works - I don't think it should, apt should probably do some locking there to prevent it from being called while installing, as it writes that file after the install is done, but apart from that, it seems good to go.

review: Approve

« Back to merge proposal