Merge ~ack/maas:1982315-use-rack-ip-if-external-dns-3.2 into maas:3.2
Proposed by
Alberto Donato
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alberto Donato | ||||
Approved revision: | 0b0b501a379151093776bc5b2a69ea64c462bc19 | ||||
Merge reported by: | MAAS Lander | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~ack/maas:1982315-use-rack-ip-if-external-dns-3.2 | ||||
Merge into: | maas:3.2 | ||||
Diff against target: |
163 lines (+101/-21) 2 files modified
src/maasserver/compose_preseed.py (+23/-17) src/maasserver/tests/test_compose_preseed.py (+78/-4) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Donato (community) | Approve | ||
Review via email: mp+428997@code.launchpad.net |
Commit message
LP:1982315 use rack IP instead of hostname in preseed if external DNS is used
This also makes handling of X-Forwarded-For a bit safer, since it ignores extra IPs that might come before the one from the rackd proxy (e.g. client-supplied values).
To post a comment you must log in.