Merge ~ack/maas:default-pool-highlight into maas:master

Proposed by Alberto Donato
Status: Merged
Approved by: Alberto Donato
Approved revision: 305b5106ce904eb52d58b914deaed030c12acc77
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ack/maas:default-pool-highlight
Merge into: maas:master
Diff against target: 50 lines (+11/-1)
3 files modified
src/maasserver/static/partials/nodes-list.html (+3/-1)
src/maasserver/websockets/handlers/resourcepool.py (+1/-0)
src/maasserver/websockets/handlers/tests/test_resourcepool.py (+7/-0)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
MAAS Lander unittests Pending
Review via email: mp+347138@code.launchpad.net

Commit message

LP: #1774023 - Report the default pool as such in the pool listing

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) :
review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/nodes-list.html b/src/maasserver/static/partials/nodes-list.html
2index 6eb9e63..d6ac125 100644
3--- a/src/maasserver/static/partials/nodes-list.html
4+++ b/src/maasserver/static/partials/nodes-list.html
5@@ -994,7 +994,9 @@ sudo maas-rack register --url {$ tabs.controllers.registerUrl $} --secret {$ tab
6 data-ng-repeat="pool in tabs.pools.filtered_items = (pools | orderBy:tabs.pools.predicate:tabs.pools.reverse) track by pool.name"
7 data-ng-class="{'is-active': tabs.pools.isPoolAction(pool)}">
8 <td class="p-table__cell col-3" aria-label="Name">
9- <span ng-if="!tabs.pools.isPoolAction(pool, 'edit')">{$ pool.name $}</span>
10+ <span ng-if="!tabs.pools.isPoolAction(pool, 'edit')">
11+ {$ pool.name $} <span ng-if="pool.is_default">(default)</span>
12+ </span>
13 <maas-obj-field
14 ng-if="tabs.pools.isPoolAction(pool, 'edit')"
15 type="text" key="name" disable-label="true" subtle="false"
16diff --git a/src/maasserver/websockets/handlers/resourcepool.py b/src/maasserver/websockets/handlers/resourcepool.py
17index aba12bd..46b1c23 100644
18--- a/src/maasserver/websockets/handlers/resourcepool.py
19+++ b/src/maasserver/websockets/handlers/resourcepool.py
20@@ -64,4 +64,5 @@ class ResourcePoolHandler(TimestampedModelHandler):
21 """
22 for attr in ['machine_total_count', 'machine_ready_count']:
23 data[attr] = getattr(obj, attr)
24+ data['is_default'] = obj.is_default()
25 return data
26diff --git a/src/maasserver/websockets/handlers/tests/test_resourcepool.py b/src/maasserver/websockets/handlers/tests/test_resourcepool.py
27index 3de83c6..cc6df3a 100644
28--- a/src/maasserver/websockets/handlers/tests/test_resourcepool.py
29+++ b/src/maasserver/websockets/handlers/tests/test_resourcepool.py
30@@ -25,6 +25,7 @@ class TestResourcePoolHandler(MAASServerTestCase):
31 {'id': pool.id,
32 'name': pool.name,
33 'description': pool.description,
34+ 'is_default': False,
35 'created': dehydrate_datetime(pool.created),
36 'updated': dehydrate_datetime(pool.updated),
37 'machine_total_count': 0,
38@@ -49,6 +50,12 @@ class TestResourcePoolHandler(MAASServerTestCase):
39 self.assertEqual(2, result['machine_total_count'])
40 self.assertEqual(1, result['machine_ready_count'])
41
42+ def test_get_is_default(self):
43+ pool = ResourcePool.objects.get_default_resource_pool()
44+ handler = ResourcePoolHandler(factory.make_User(), {})
45+ result = handler.get({"id": pool.id})
46+ self.assertTrue(result['is_default'])
47+
48 def test_list(self):
49 user = factory.make_User()
50 handler = ResourcePoolHandler(user, {})

Subscribers

People subscribed via source and target branches