Code review comment for lp:~ack/landscape-client/package-reporter-permissions

Revision history for this message
Thomas Herve (therve) wrote :

[1]
- def run_process(self, command, args):
+ def _run_process(self, command, args, env={}, path=None, uid=None, gid=None):

I don't see the point of having env and path here, as you never pass them. But you always pass uid and gid, so they shouldn't be optional.

+1!

review: Approve

« Back to merge proposal