Merge ~ack/gitlptools:snap-core22 into gitlptools:master

Proposed by Alberto Donato
Status: Merged
Approved by: Adam Collard
Approved revision: 019ba69169bb1bbac69b7873026207dd557ef032
Merged at revision: d5b6b8b8cda55571839bba3ff908d9dc3fe0a6e1
Proposed branch: ~ack/gitlptools:snap-core22
Merge into: gitlptools:master
Diff against target: 132 lines (+38/-48)
3 files modified
setup.cfg (+26/-0)
setup.py (+1/-18)
snap/snapcraft.yaml (+11/-30)
Reviewer Review Type Date Requested Status
Adam Collard Pending
Review via email: mp+430550@code.launchpad.net

Commit message

move snap to core22, move setup metadata to setup.cfg

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/setup.cfg b/setup.cfg
index 601a2f3..0abdf7b 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,3 +1,29 @@
1[metadata]
2name = gitlptools
3version = 1.0
4
5[options]
6packages = find:
7package_dir =
8 = src
9setup_requires =
10 pytest-runner
11tests_require =
12 pytest
13install_requires =
14 attrs
15 GitPython
16 launchpadlib
17
18[options.packages.find]
19where = src
20
21[options.entry_points]
22console_scripts =
23 git-lp-approve = gitlptools:git_lp_approve
24 git-lp-open = gitlptools:git_lp_open
25 git-lp-propose = gitlptools:git_lp_propose
26
1[aliases]27[aliases]
2test=pytest28test=pytest
329
diff --git a/setup.py b/setup.py
index f172873..d903a55 100755
--- a/setup.py
+++ b/setup.py
@@ -5,21 +5,4 @@
55
6from setuptools import setup6from setuptools import setup
77
88setup()
9VERSION = '1.0'
10
11
12setup(
13 name='gitlptools',
14 version=VERSION,
15 packages=['gitlptools'],
16 package_dir={'': 'src'},
17 setup_requires=['pytest-runner'],
18 tests_require=['pytest'],
19 install_requires=['attrs', 'GitPython', 'launchpadlib'],
20 entry_points={
21 'console_scripts': ['git-lp-approve=gitlptools:git_lp_approve',
22 'git-lp-open=gitlptools:git_lp_open',
23 'git-lp-propose=gitlptools:git_lp_propose'],
24 }
25)
diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index bc3c236..c1d2f7c 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -1,5 +1,4 @@
1name: gitlptools1name: gitlptools
2version: git
3summary: Tools to make git work well with Launchpad2summary: Tools to make git work well with Launchpad
4description: |3description: |
5 A collection of plugins to make working with git and Launchpad a nicer4 A collection of plugins to make working with git and Launchpad a nicer
@@ -8,49 +7,31 @@ description: |
8grade: stable7grade: stable
9confinement: classic # Needs classic, since we don't know which git repos it8confinement: classic # Needs classic, since we don't know which git repos it
10 # wants to access.9 # wants to access.
11base: core2010base: core22
11adopt-info: gitlptools
1212
13apps:13apps:
14 git-lp-approve:14 git-lp-approve:
15 command: bin/python3 $SNAP/bin/git-lp-approve15 command: bin/git-lp-approve
16 git-lp-open:16 git-lp-open:
17 command: bin/python3 $SNAP/bin/git-lp-open17 command: bin/git-lp-open
18 git-lp-propose:18 git-lp-propose:
19 command: bin/python3 $SNAP/bin/git-lp-propose19 command: bin/git-lp-propose
2020
21parts:21parts:
22 gitlptools:22 gitlptools:
23 # See 'snapcraft plugins'23 # See 'snapcraft plugins'
24 plugin: python24 plugin: python
25 source: .25 source: .
26 # python3-oauth is needed since the version on pypi doesn't support26 python-packages:
27 # Python3.27 - keyring
28 # python3-secretstorage is needed so that the LP API credentials can28 - keyrings.alt
29 # be saved somewhere.29 - SecretStorage
30 # The keyring packages are needed so that launchpadlib has a place
31 # to store its secrets when running inside containers.
32 stage-packages:
33 - python3-oauth
34 - python3-secretstorage
35 - python3-keyring
36 - python3-keyrings.alt
37 - python3-gi
38 - libpython3-stdlib
39 - libpython3.8-stdlib
40 - libpython3.8-minimal
41 - python3-wheel
42 - python3-venv
43 - python3-minimal
44 - python3-distutils
45 - python3-pkg-resources
46 - python3.8-minimal
47 override-build: |30 override-build: |
48 snapcraftctl build31 craftctl default
4932
50 version="$(git rev-parse --short HEAD)"33 version="$(git rev-parse --short HEAD)"
51 snapcraftctl set-version "$version"34 craftctl set version="$version"
52
53 ln -sf ../usr/bin/python3.8 $SNAPCRAFT_PART_INSTALL/bin/python3
5435
55 elisp:36 elisp:
56 plugin: dump37 plugin: dump

Subscribers

People subscribed via source and target branches