Merge ~ack/gitlptools:snap-core22 into gitlptools:master

Proposed by Alberto Donato
Status: Merged
Approved by: Adam Collard
Approved revision: 019ba69169bb1bbac69b7873026207dd557ef032
Merged at revision: d5b6b8b8cda55571839bba3ff908d9dc3fe0a6e1
Proposed branch: ~ack/gitlptools:snap-core22
Merge into: gitlptools:master
Diff against target: 132 lines (+38/-48)
3 files modified
setup.cfg (+26/-0)
setup.py (+1/-18)
snap/snapcraft.yaml (+11/-30)
Reviewer Review Type Date Requested Status
Adam Collard Pending
Review via email: mp+430550@code.launchpad.net

Commit message

move snap to core22, move setup metadata to setup.cfg

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/setup.cfg b/setup.cfg
2index 601a2f3..0abdf7b 100644
3--- a/setup.cfg
4+++ b/setup.cfg
5@@ -1,3 +1,29 @@
6+[metadata]
7+name = gitlptools
8+version = 1.0
9+
10+[options]
11+packages = find:
12+package_dir =
13+ = src
14+setup_requires =
15+ pytest-runner
16+tests_require =
17+ pytest
18+install_requires =
19+ attrs
20+ GitPython
21+ launchpadlib
22+
23+[options.packages.find]
24+where = src
25+
26+[options.entry_points]
27+console_scripts =
28+ git-lp-approve = gitlptools:git_lp_approve
29+ git-lp-open = gitlptools:git_lp_open
30+ git-lp-propose = gitlptools:git_lp_propose
31+
32 [aliases]
33 test=pytest
34
35diff --git a/setup.py b/setup.py
36index f172873..d903a55 100755
37--- a/setup.py
38+++ b/setup.py
39@@ -5,21 +5,4 @@
40
41 from setuptools import setup
42
43-
44-VERSION = '1.0'
45-
46-
47-setup(
48- name='gitlptools',
49- version=VERSION,
50- packages=['gitlptools'],
51- package_dir={'': 'src'},
52- setup_requires=['pytest-runner'],
53- tests_require=['pytest'],
54- install_requires=['attrs', 'GitPython', 'launchpadlib'],
55- entry_points={
56- 'console_scripts': ['git-lp-approve=gitlptools:git_lp_approve',
57- 'git-lp-open=gitlptools:git_lp_open',
58- 'git-lp-propose=gitlptools:git_lp_propose'],
59- }
60-)
61+setup()
62diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
63index bc3c236..c1d2f7c 100644
64--- a/snap/snapcraft.yaml
65+++ b/snap/snapcraft.yaml
66@@ -1,5 +1,4 @@
67 name: gitlptools
68-version: git
69 summary: Tools to make git work well with Launchpad
70 description: |
71 A collection of plugins to make working with git and Launchpad a nicer
72@@ -8,49 +7,31 @@ description: |
73 grade: stable
74 confinement: classic # Needs classic, since we don't know which git repos it
75 # wants to access.
76-base: core20
77+base: core22
78+adopt-info: gitlptools
79
80 apps:
81 git-lp-approve:
82- command: bin/python3 $SNAP/bin/git-lp-approve
83+ command: bin/git-lp-approve
84 git-lp-open:
85- command: bin/python3 $SNAP/bin/git-lp-open
86+ command: bin/git-lp-open
87 git-lp-propose:
88- command: bin/python3 $SNAP/bin/git-lp-propose
89+ command: bin/git-lp-propose
90
91 parts:
92 gitlptools:
93 # See 'snapcraft plugins'
94 plugin: python
95 source: .
96- # python3-oauth is needed since the version on pypi doesn't support
97- # Python3.
98- # python3-secretstorage is needed so that the LP API credentials can
99- # be saved somewhere.
100- # The keyring packages are needed so that launchpadlib has a place
101- # to store its secrets when running inside containers.
102- stage-packages:
103- - python3-oauth
104- - python3-secretstorage
105- - python3-keyring
106- - python3-keyrings.alt
107- - python3-gi
108- - libpython3-stdlib
109- - libpython3.8-stdlib
110- - libpython3.8-minimal
111- - python3-wheel
112- - python3-venv
113- - python3-minimal
114- - python3-distutils
115- - python3-pkg-resources
116- - python3.8-minimal
117+ python-packages:
118+ - keyring
119+ - keyrings.alt
120+ - SecretStorage
121 override-build: |
122- snapcraftctl build
123+ craftctl default
124
125 version="$(git rev-parse --short HEAD)"
126- snapcraftctl set-version "$version"
127-
128- ln -sf ../usr/bin/python3.8 $SNAPCRAFT_PART_INSTALL/bin/python3
129+ craftctl set version="$version"
130
131 elisp:
132 plugin: dump

Subscribers

People subscribed via source and target branches