Code review comment for lp:~ack/charms/trusty/keystone/pause-and-resume

Thank you for your work on this. These will be great test additions.

I'd like to see the added amulet tests and helpers land in basic_deployment.py (or charmhelpers where appropriate) so that we can maintain consistency across the os-charms in the way that we iterate ubuntu/openstack series/release.

This means adding new test_ methods in basic_deployment.py, each of which should be idempotent, and not dependent on the run order of the other tests.

If there are OpenStack-specific, amulet-specific helpers which are useful in other charm tests, please land those in charmhelpers/contrib/openstack/amulet/utils.py.

If there are non-OpenStack-specific, amulet-specific helpers which are useful in other charm tests, please land those in charmhelpers/contrib/amulet/utils.py.

Often times, during test dev, I'll keep all of my helpers as local helpers in basic_deployment.py. Then once I have them the way that I want them, pluck them out into charmhelpers if they are potentially useful for writing tests in other charms.

Feel free to holler with any questions. Thanks again!